Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Copy ID + Auto Update Members #732

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Copy ID + Auto Update Members #732

merged 8 commits into from
Oct 23, 2023

Conversation

achoi51
Copy link
Member

@achoi51 achoi51 commented Oct 8, 2023

Enhancement for Copy ID #722 (set to admin only)
Auto Update Members for approving/rejecting members as well as removing one. #725 and #717
Also fixes #190 with a loading sign
ALSO fixes meetings not auto updating

Enhancement for Copy ID #722
Auto Update Members for approving/rejecting members as well as removing one. #725 and #717
@SnowyNate
Copy link

SnowyNate commented Oct 8, 2023

TEST PERFORMED BY NATE - 10/8/23

  • The member requests and members tabs are updated when approving and rejecting a member request

- [ ] For the user requesting to be accepted into a club, it doesn't update for them- not sure if you can fix that but that is an issue - Issue fix is unnecessary

  • Copy ID set to Sitewide Admin only? @TheEgghead27 @GandyT , up to you guys to test; other issues look like they're fixed!

achoi51 and others added 5 commits October 8, 2023 15:58
just some stuff I forgot to fix lol
Each adminRole belongs to a set of undocumented strings, not including
"admin". "meetings" and "charters" have been used instead.
@TheEgghead27
Copy link
Member

I owe you a much more extensive review; very sorry about that! So far, looking great!
I hope to fully review and merge this next weekend (after end-of-marking period exams).

@TheEgghead27
Copy link
Member

Amazing! Looks like you fixed all of those bugs on the frontend!
I won't close stuysu/api.stuyactivities.org#742 for now since that remains an API misimplementation (which we may ignore to prioritize StuyActivities 3.0)

Copy link
Member

@TheEgghead27 TheEgghead27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Just going to get rid of a few Prettier-inserted spaces (ick), then merge!

{org.membership?.adminPrivileges && (
<TabItem label={"Admin Panel"} exact={false} to={match.path + "/admin"} icon={<Settings />} />
)}
{user?.adminRoles?.some(s => s.role === "admin") && (
<FlexCenter>
<Button onClick={CopyOrgId}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, test and verify these buttons, so far looking great

@TheEgghead27 TheEgghead27 merged commit 9beb9f2 into master Oct 23, 2023
4 of 5 checks passed
@TheEgghead27 TheEgghead27 deleted the AChoi51-patch-1 branch October 23, 2023 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants